Conversation
The -term_timeout flag was hardcoded to 30s. For services that run long-lived jobs (e.g. Netex batch processing), the proxy closes database connections after 30s even though the pod's terminationGracePeriodSeconds allows much longer. This causes in-flight jobs to lose their DB connection mid-run during rolling deployments. Adding postgres.termTimeout allows each chart consumer to set a timeout appropriate for their workload, while keeping 30s as the default.
thomass-entur
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What and why
The Cloud SQL Proxy sidecar has
-term_timeouthardcoded to30s. This controls how long the proxy waits for existing connections to drain after receivingSIGTERMbefore force-closing them.For services with long-lived jobs (e.g. batch processing that writes to the database), the proxy tears down database connections after 30s even when the pod's
terminationGracePeriodSecondsis set much higher. This causes in-flight jobs to lose their DB connection mid-run during rolling deployments.Changes
_helpers.tpl: replace hardcoded-term_timeout=30swith{{ .postgres.termTimeout | default "30s" }}— backwards compatible, default unchangedvalues.yaml: addpostgres.termTimeoutwith doc commentChart.yaml: bump to1.21.2Testing
Consumers can now set:
to align the proxy's connection drain timeout with their pod's
terminationGracePeriodSeconds.